Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audit-viewer - Audit event viewer https://bugzilla.redhat.com/show_bug.cgi?id=442522 lkundrak@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From lkundrak@xxxxxxxxxx 2008-04-18 18:36 EST ------- (In reply to comment #7) > (In reply to comment #3) > > 4.) rpmlint: > > audit-viewer.src: W: no-url-tag > Added, now that audit-viewer is at fedorahosted.org Not really -- you just added a comment, not changed the URL tag. Given this is an upstream issue and relation between upstream and package is not relevant here, it can not block the review. I encourage you to upload the source to https://fedorahosted.org/releases/ and change the url tag respectively as described here: https://fedorahosted.org/web/faq > > > audit-viewer.x86_64: W: symlink-should-be-relative > > /usr/libexec/audit-viewer-server /usr/bin/consolehelper > > Absolute symlinks are problematic eg. when working with chroot environments. > There's really no way to use that symlink in a chroot anyway: > - There's no reason to use it to copy the consolehelper binary anywhere. > - If you use the symlink to run audit-viewer-server, then consolehelper > will access /etc/security/console.apps/audit-viewer-server, check users > from /etc/passwd and run /usr/libexec/audit-viewer-server-real; this will > all happen in the "top" root and it will happen the same whether the > running consolehelper is /usr/bin/consolehelper or > /chroot/usr/bin/consolehelper. > OTOH using an absolute symlink somewhat protect us in case %{libexecdir} was moved. I don't believe there's a guideline for these and was not able to find any. I see no more problems with the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review