Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eet - Library for speedy data storage, retrieval, and compression https://bugzilla.redhat.com/show_bug.cgi?id=441965 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2008-04-18 13:37 EST ------- Each time you modify your package, you should increment the release number, and redo a .src.rpm and repost the link to the modified .src.rpm. There are some warnings about missing declarations corresponding with missing includes that should be fixed, if possible: eet_image.c: In function 'eet_data_image_lossless_convert': eet_image.c:384: warning: implicit declaration of function 'htonl' eet_lib.c: In function 'eet_open': eet_lib.c:1173: warning: implicit declaration of function 'unlink' htonl: #include <arpa/in.h> unlink: #include <unistd.h> I suggest using make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' to keep timestamps of installed files. The -devel subpackage should depend on pkgconfig. rpmlint is silent. The source timestamp is not kept: $ ls -l eet-0.9.99900.tar.bz2 ../SOURCES/eet-0.9.99900.tar.bz2 -rw-rw-r-- 1 pat pat 2788829 mar 31 22:08 eet-0.9.99900.tar.bz2 -rw-rw-r-- 1 pat pat 2788829 avr 4 14:21 ../SOURCES/eet-0.9.99900.tar.bz2 but match upstream: c9f75595152f571139df450314bdb5fc eet-0.9.99900.tar.bz2 Some documentation should be shipped, either in a -doc subpackage, or in the devel package. I suggest shipping doc/html/. You can use wget -N, or spectool -g. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review