[Bug 437667] Review Request: dvipdfm - A DVI to PDF converter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipdfm - A DVI to PDF converter


https://bugzilla.redhat.com/show_bug.cgi?id=437667





------- Additional Comments From pertusus@xxxxxxx  2008-04-17 17:10 EST -------
Looks good. Still some little issues:

* the comment explaining the tex(tex) BR is a bit wrong now, since it is
also used to build the documentation.

* I think it would be better to have another name for the config file, 
it is not very specific (especially for those who have a shared SOURCES
directory), like dvipdfm-config.

* I suggest using
%makeinstall INSTALL='install -p'
to keep timestamps.


* There are Requires(post): /usr/bin/mktexlsr
but it is not used. Since there are files in texmf_main, I guess that 
the calls should be done.

* I think it is better to have
rm dvipdft
instead of
rm -f dvipdft
to be warned when upstream changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]