Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eg - Git for mere mortals https://bugzilla.redhat.com/show_bug.cgi?id=442914 dan@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dan@xxxxxxxx 2008-04-17 15:49 EST ------- OK source files match upstream (diff between supplied archive and the one produced directly from git is empty) OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPL). License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (rawhide/X86_64). N/A debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. N/A no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. rpmlint output: eg.noarch: I: checking eg.noarch: W: non-conffile-in-etc /etc/bash_completion.d/eg eg.src: I: checking This a common issue of packages with "bash completion" support where /etc/bash_completion.d directory owned by the package. Trigger based solution is mentioned at http://fedoraproject.org/wiki/ToshioKuratomi/TriggerScripts. package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review