Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fox - A C++ library for GUI development https://bugzilla.redhat.com/show_bug.cgi?id=431665 ------- Additional Comments From pertusus@xxxxxxx 2008-04-16 17:55 EST ------- I won't accept a package that ships binary named PathFinder or calculator. There should be dots at the end of the %description texts. Why the Requires: bzip2, zlib The libs should be auto-detected, so why this Requires? For the .pc patch, unless I am missing something, there are still some libs that are only linked through fox (though the double quote seems to confuse pkgconfig, and now the libs needed when statically linking are not present anymore. In my opinion, it should end up like (also note that the double quotes should not be there, I removed them): .... LIBS=@LIBS@ FOX_LIBS=-lFOX-@FOX_MAJOR_VERSION@.@FOX_MINOR_VERSION@ X_LIBS=@X_LIBS@ X_BASE_LIBS=@X_BASE_LIBS@ X_EXTRA_LIBS=@X_EXTRA_LIBS@ GL_LIBS=@GL_LIBS@ Name: FOX Description: The FOX Toolkit URL: www.fox-toolkit.com Version: @FOX_MAJOR_VERSION@.@FOX_MINOR_VERSION@.@FOX_PATCH_LEVEL@ Libs: ${FOX_LIBS} Libs.private: ${X_LIBS} ${X_BASE_LIBS} ${X_EXTRA_LIBS} ${GL_LIBS} ${LIBS} Cflags: -I${includedir} Also the fedora opt flags are not used. With a release, the autoconf call is not needed (and may be harmful). Regarding the fox-config file, I think it should better be completly rewritten as a pkgconfig wrapper. I'll attach it. You can then propose it to upstream to install it as, for example fox-config-pkgconfig, and then in the fedora package you ship fox-config-pkgconfig as fox-config. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review