Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libgphoto2 - Library for accessing digital cameras https://bugzilla.redhat.com/show_bug.cgi?id=437285 ------- Additional Comments From jnovy@xxxxxxxxxx 2008-04-16 12:39 EST ------- (In reply to comment #3) > Full review done: > > * This %define (luckily) does not seem to be used, please remove: > # Arches on which we need to prevent arch conflicts in gphoto2-config > %define multilib_arches %{ix86} ia64 ppc ppc64 s390 s390x x86_64 Makes sense, removed. > * I suppose this using 0.x scheme is only for the review, and you will jump to > 1%{?dist} after review? > Release: 0.1%{?dist} Yup, the 0.x versioning is used just for review. > > * Source0: http://prdownloads.sourceforge.net/gphoto/libgphoto2-%{version}.tar.bz2 > > That is not the prefered form for a sf.net download url, that should be: > > Source0: http://downloads.sourceforge.net/gphoto/libgphoto2-%{version}.tar.bz2 > Updated. > * Is this really needed? : > ExcludeArch: s390 s390x > > I understand libgphoto is almost useless there, but it might be handy to still > have it so that applications which can use it don't have to have their specfiles > filled with %ifarch Ok, libgphoto2 is now compiled also for s390, s390x > * You should preserve the timestamps while converting the docs, so replace: > for i in AUTHORS COPYING; do > cp ${i} ${i}.old > iconv -f cp1250 -t utf-8 < ${i}.old > ${i} > rm -f ${i}.old > done > > with > for i in AUTHORS COPYING; do > mv ${i} ${i}.old > iconv -f cp1250 -t utf-8 < ${i}.old > ${i} > touch -r ${i}.old ${i} > rm -f ${i}.old > done Applied. > * License tag is wrong, the following source files are not LGPLv2+ > > GPLv2: > camlibs/adc65/adc65.c > > GPLv2+: > camlibs/fuji/fuji.c > camlibs/minolta/dimagev/* > camlibs/mustek/* > camlibs/stv0680/* > libgphoto2/exif.c > > LGPLv2: > camlibs/sipix/blink.c > > So the correct license lines would be: > # GPLV2+ for the main lib (due to exif.c) and most plugins, some plugins GPLv2 > License: GPLv2+ and GPLv2 > Fixed. > * The descriptions need to be updated for the fact that this package now only > contains a lib and no longer the gphoto2 application. > I grabbed the description from the README file, hope it's sufficient. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review