Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tinyproxy - A small, efficient HTTP/SSL proxy daemon https://bugzilla.redhat.com/show_bug.cgi?id=436716 ------- Additional Comments From kevin@xxxxxxxxx 2008-04-15 23:08 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. See below - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: bd14d029b12621bcfd7ee71b2f4893da tinyproxy-1.6.3.tar.gz bd14d029b12621bcfd7ee71b2f4893da tinyproxy-1.6.3.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Use $RPM_BUILD_ROOT or %{buildroot} style macros, don't mix. ;) 2. Looks like you are missing some Requires for the init script/chkconfig calls. See: http://fedoraproject.org/wiki/Packaging/SysVInitScript#head-91577460937bcc1e94127ca00afd8e69274823b0 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review