Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dnx - Distributed Nagios Executor https://bugzilla.redhat.com/show_bug.cgi?id=441570 ------- Additional Comments From xavier@xxxxxxxxxxxx 2008-04-14 11:21 EST ------- License: does not match the guidelines. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines Source: should be a full url. There are specific rules in the packaging guidelines for Sourceforge URLs. http://fedoraproject.org/wiki/Packaging/SourceURL BuildRoot: doesn't match the guidelines. http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 There are specific rules on how to create an user. http://fedoraproject.org/wiki/Packaging/UsersAndGroups initscript is not handled properly : http://fedoraproject.org/wiki/Packaging/SysVInitScript#head-91577460937bcc1e94127ca00afd8e69274823b0 Some files path should be replaced by macros : /var/log %{_localstatedir}/log /etc/nagios %{sysconfdir}/nagios %{_prefix}/bin %{_bindir} Stopping the nagios server on %%preun looks a bit suspicious to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review