Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cython - This is a development version of Pyrex, a language for writing Python extension modules. https://bugzilla.redhat.com/show_bug.cgi?id=435090 ------- Additional Comments From jamatos@xxxxxxxx 2008-04-14 07:52 EST ------- Needs work: * Source Cython-0.9.6.13.1.tar.gz is different from upstream (wiki: QAChecklist item 2) using md5sum I get: b84818d4cfcec68e6dfb71187e9f0b4b upstream 3b7bde3b0869b3624cd80fe5cde4e2ed srpm * rpmlint of source RPM: Cython.src: W: mixed-use-of-spaces-and-tabs (spaces: line 22, tab: line 1) Cython.src: W: invalid-license PSFL * rpmlint of Cython: Cython.noarch: W: file-not-utf8 /usr/share/doc/Cython-0.9.6.13.1/CHANGES_pyrex.txt Cython.noarch: W: invalid-license PSFL The license should be Python. The mixed use of spaces and tabs is easy to fix and the other warning is just that. :-) * %files According to http://fedoraproject.org/wiki/Packaging/Python /!\ You shouldn't rely on INSTALLED_FILES, as that will not list directories, which will need to be specified in the %files section as well. Using globs in the %files section is safer. * %description You refer Doc/About.html but that file is not packaged. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review