Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mono-nunit22 - Unit-testing framework for .NET https://bugzilla.redhat.com/show_bug.cgi?id=442057 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-04-11 11:43 EST ------- This builds OK (although the output is crazy verbose); rpmlint says: mono-nunit22.x86_64: W: invalid-license MIT with acknowledgement rpmlint is a bit behind here. mono-nunit22.x86_64: E: no-binary mono-nunit22.x86_64: E: only-non-binary-in-usr-lib These are normal for mono packages. mono-nunit22-debuginfo.x86_64: E: empty-debuginfo-package Indeed, the debuginfo package seems to be completely empty. Probably best to disable it. mono-nunit22-devel.x86_64: W: no-documentation That's OK; it's just a .pc file. I'm going to trust your evaluation of the license so that I don't have to open a damn rtf viewer. The world is just full of idiocy, it seems. So the only issue is the empty debuginfo package; I'll approve this and you can disable it when you check in. * source files match upstream: 181ed056855cb8490d3ef5d0763d7a7a90c44402b7dcbb4a3341f80dbb75b9d4 NUnit-2.2.10-src.zip * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. X debuginfo package is busted. X rpmlint has a valid complaint about the debuginfo package. * final provides and requires are sane: mono-nunit22-2.2.10-1.fc9.x86_64.rpm mono(nunit-console) = 0.0.0.0 mono(nunit-console-runner) = 2.2.10.0 mono(nunit.core) = 2.2.10.0 mono(nunit.core.extensions) = 2.2.10.0 mono(nunit.framework) = 2.2.10.0 mono(nunit.mocks) = 2.2.10.0 mono(nunit.util) = 2.2.10.0 mono-nunit22 = 2.2.10-1.fc9 = mono(System) = 2.0.0.0 mono(System.Xml) = 2.0.0.0 mono(mscorlib) = 2.0.0.0 mono(nunit-console-runner) = 2.2.10.0 mono(nunit.core) = 2.2.10.0 mono(nunit.framework) = 2.2.10.0 mono(nunit.util) = 2.2.10.0 mono-nunit22-devel-2.2.10-1.fc9.x86_64.rpm mono-nunit22-devel = 2.2.10-1.fc9 = mono-nunit22 = 2.2.10-1.fc9 pkgconfig * %check is not present. I there are tests, but they're run at build time. At least that's what it looks like the build-tests targets are doing. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * pkgconfig file is (alone) in the -devel package. APPROVED; just disable the debuginfo package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review