Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: luadoc - Documentation Generator Tool for Lua https://bugzilla.redhat.com/show_bug.cgi?id=440681 michel.sylvan@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From michel.sylvan@xxxxxxxxx 2008-04-10 14:21 EST ------- • rpmlint: OK • package name: OK • spec file name: OK • package guideline-compliant: OK • license complies with guidelines: OK • license field accurate: OK • license file not deleted: OK • spec in US English: OK • spec legible: OK • source matches upstream: OK • builds under >= 1 archs, others excluded: noarch • build dependencies complete: OK • locales handled using %find_lang, no %{_datadir}/locale: N/A • library -> ldconfig: N/A • relocatable: give reason: N/A • own all directories: See note below • no dupes in %files: OK • permission: OK • %clean RPM_BUILD_ROOT: OK • macros used consistently: OK • Package contains code: OK • large docs => -doc: N/A • clean buildroot before install: OK • filenames UTF-8: OK SHOULD • package build in mock on all architectures: OK • package functioned as described: OK • scriplets are sane: OK • require package not files: OK Note: both luadoc and lua-logging requires lua >= 5.1, but install files under %{_datadir}/lua/5.1 . Perhaps make them also require lua < 5.2 ? Otherwise things will break when lua 5.2 is released: users might end up with dangling /usr/share/lua/5.1 directories APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review