Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: konq-plugins - Additional plugins that interact with konqueror https://bugzilla.redhat.com/show_bug.cgi?id=438126 ------- Additional Comments From fedora@xxxxxxxxxxxxxx 2008-04-09 04:28 EST ------- (In reply to comment #10) > [x] Rpmlint output: > source RPM: > W: patch-not-applied Patch2: konq-plugins-4.0.1-icons.patch > -> Sebastian ? Should this patch be applied ? No, it's not needed anymore. I'll remove it. > [!] Latest version is packaged. > not a problem, the package uses svn version 4.0.2, meanwhile 4.0.3 has been > released. As stated above, I rely on Sebastian to pick the best release to be > shipped in Fedora. konq-plugins did not get changes for a long time. The script create_tarball.rb use the actual verstion of KDE also for the created tarball. At time of creation this was 4.0.2. However, there were some changes in the past days. So I could a) update the package and submit the new version for review again b) import the package and update it after the import > 1. Not all the plugins are using the same license and they are delivered as > separate libraries. Therefore I think that the correct license tag is "GPLv2+ > and LGPLv2+" (http://fedoraproject.org/wiki/Licensing/FAQ , "Multiple licensing > situations", answer A3) Ok. I'll use "GPLv2+ and LGPLv2+" then. > 2. The autorefresh plugin has no license specified. IANAL, but I am almost > certain this has to be clarified before including it in Fedora I'll try to ping upstream to include a license in autorefresh.* files then. But what to to until then? Import it and wait for upstream or wait with the import until upstream has fixed this? > 3. One patch is included in the src.rpm but not applied. Maybe you could either > drop it, use it or add a note mentioning why is it included but not used ? See above. I'll drop it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review