Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iDesk - Desktop icons and background for minimal WMs https://bugzilla.redhat.com/show_bug.cgi?id=222998 ------- Additional Comments From pertusus@xxxxxxx 2008-04-08 09:38 EST ------- The current example is indeed better than the default one, but I would nevertheless suggest shipping folder_home.xpm be it as %doc. I would also suggest shipping the upstream examples/default.lnk in %doc. I also suggest substituting %{_datadir} to have things right even if %{_datadir} is different from /usr/share/, right after patching: sed -e -i 's:/usr/share/idesk/:%{_datadir}/idesk/:' examples/default.lnk And last, I think that it would be nice to have a comment stating where the xterm.png icon comes from. (None of these are blockers). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review