Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iDesk - Desktop icons and background for minimal WMs https://bugzilla.redhat.com/show_bug.cgi?id=222998 ------- Additional Comments From gilboad@xxxxxxxxx 2008-04-08 07:03 EST ------- (In reply to comment #26) > Suggestion: Renaming default_lnk.patch to > %{name}-%{version-when-patch-was-introduced}-default_lnk.patch will make your > life easier. ;) Semi-fixed. (I rather not put the version number in the patch - as it doesn't effect the actual code. Spec URL: http://gilboadavara.thecodergeek.com/idesk.spec SRPM URL: http://gilboadavara.thecodergeek.com/idesk-0.7.5-6.fc8.src.rpm > Final question: Why do you remove folder_home.xpm? It was required by the old (xdialog) example. As the example no longer needs it - there's no need to carry it around. > Anyway, this package finally is APPROVED. Thanks again for taking the time to the review. - Gilboa -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review