[Bug 439117] Review Request: preupgrade - Preresolves dependencies and prepares a system for an upgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: preupgrade - Preresolves dependencies and prepares a system for an upgrade


https://bugzilla.redhat.com/show_bug.cgi?id=439117





------- Additional Comments From skvidal@xxxxxxxxxxxxxx  2008-04-07 12:51 EST -------
(In reply to comment #3)
> Builds fine.  rpmlint says:
>   preupgrade.src: W: strange-permission preupgrade.spec 0600
> which is a little weird but isn't a blocker.  (If it were 666, that would be a
> problem.)

artifact of rpmbuild -ts file.tar.gz :)


 
> Is there no URL where the source can be downloaded?  Where does the tarball come
> from?

not yet, we've not exactly made an official release, yet.

 
> BuildRoot should be one of the values from
> http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot or at minimum
> should include %{release} in addition to what's there.

fixed.

 
> You can shorten BuildArchitectures: as BuildArch: if you like to save typing. 
> (I only mention it because vim highlights it oddly; the 'itectures' is a
> different color.)

fixed.

> 
> You can remove the tests that ensure the buildroot isn't '/'; rpmbuild does that
> for you.

fixed.

> 
> I was under the impression that Red Hat-developed code was GPLv2 only.  Not
> really my business as the License: tag matches the source code, but I figured
> I'd ask.

that's news to me. Where did you see that?

> 
> I notice you don't use the dist tag.  Your choice, of course; I assume you know
> how to deal with its absence.

we'll add it b/c we will need it.

 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]