Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Supybot - Cross-platform IRC bot written in Python https://bugzilla.redhat.com/show_bug.cgi?id=436568 ------- Additional Comments From ricky.zhou@xxxxxxxxx 2008-04-06 02:47 EST ------- (In reply to comment #16) > But, as you have anticipated, including private copies of python modules is a > big NO NO (in my opinion at least). Maybe this would not violate the letter of > http://fedoraproject.org/wiki/Packaging/Guidelines#head-17396a3b06ec849a7c0c6fc3243673b17e5fed90 > but would definitely contradict the spirit. Yeah, I definitely agree. Here's what I've done: plugins/Dict/dictclient.py: Submitted a review request for python-dictclient (bug #441098). It seems very old (2002) and I'm not sure how well-maintained it is, but it seems useful for the Supybot plugin (and other uses). plugins/Google/*: I just deleted this plugin entirely. Google doesn't even give SOAP API keys anymore, so this shouldn't be a huge loss. plugins/Math/convertcore.py: I left this one in, since it is a modified module from a GPLed project (as mentioned at the top of the file). I changed the license tag and added a comment to clarify. plugins/RSS/feedparser.py: Deleted. This is provided by python-feedparser. plugins/Time/dateutil/*: Deleted. This is provided by python-dateutil. Once again, I'm not requiring any of those modules because they aren't absolutely necessary for the operation of Supybot. How do you suggest that I document the requirements for certain plugins, though? Should I mention these in some sort of README.fedora or something? Spec URL: http://ricky.fedorapeople.org/pkgs/Supybot/Supybot.spec SRPM URL: http://ricky.fedorapeople.org/pkgs/Supybot/Supybot-0.83.3-3.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review