Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ufiformat - Disk formatting utility for USB floppy devices https://bugzilla.redhat.com/show_bug.cgi?id=438406 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-04-05 20:18 EST ------- Thre is one small change I recommend. It is mostly cosmetic but makes the package closer to "preserve timestamps" rule we try to enforce. Please replace: make install DESTDIR=$RPM_BUILD_ROOT with make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" This will preserve the timestamp of the man page. For the rest I concur with Kairo. No need to re-upload the spec/src.rpm just for that, just keep it mind and make sure you add the modification before uploading to CVS, once your package is officialy approved. Chris, I've noticed that you are quite active as a bug reporter and that you have also used mock in the past to rebuild packages locally. I am willing to sponsor you, but before that I would like to either see a couple of [unofficial] reviews performed by you or at least another packaged submitted by you. Could you please do that ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review