Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Propel - An Object Relational Mapping (ORM) framework for PHP5 https://bugzilla.redhat.com/show_bug.cgi?id=266841 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |182235 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-04-04 23:55 EST ------- Finally have some time. This builds OK; rpmlint says: php-pear-propel_runtime.src:106: W: macro-in-%changelog buildroot You need to double percent signs in your changelog so that they aren't expanded. php-pear-propel_runtime.noarch: W: no-documentation which is true; there doesn't seem to be any documentation at all in the tarball. The license is a bit odd. First off, I think it's LGPLv2+, because the version is not specified anywhere and the LGPL allows us to choose any version at all in that case. However, if you look upstream, they say that they've relicensed Apache 2 licenced code to LGPL. I sort of understand what the situation would be if they had licensed to GPL, as only GPLv3 is compatible with ASLv2 so the result would be GPLv3+. But I really don't know about LGPL. Honestly seeing that they've just decided to relicense others code to an incompatible license makes me rather nervous. Blocking legal for input on the license compatibility, and someone should really check with upstream about what version of the LGPL they actually intend. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review