Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mediawiki-StubManager - An extension meant to address 'rare events' handling https://bugzilla.redhat.com/show_bug.cgi?id=439338 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-04-04 22:04 EST ------- Not much to this, it seems. I guess the package.xml file is the only place to find the license; the code itself carries no license info. * source files match upstream: f138f70a4ab984c3d5d2087f475bb444f78f68cb950de02756073cc92b5fc700 3_01.txt 96b8d6df0aaea17d68997b637027793517be3bbbdce632ba12f8f283aab64020 StubManager-1.2.0.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: mediawiki-StubManager = 1.2.0-1.fc9 = mediawiki >= 1.10 * %check is not present; no test suite upstream. I'm not sure how you would go about testing this, anyway. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Ping me when this is in rawhide and I'll review mediawiki-HNP. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review