Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: stringtemplate - A Java template engine https://bugzilla.redhat.com/show_bug.cgi?id=439911 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-04-04 18:27 EST ------- I noticed something that looks like a test suite; it is possible to run it at build time? The package seems to be missing a versioned dependency on java as required by the guidelines. * source files match upstream: 59fa7e74646ef4767a6d55356c580d5f24d1392ef89fbd0c435c6426353aaf7c stringtemplate-3.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. X license text in tarball but not included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly X rpmlint has valid complaints. X final provides and requires not quite correct: stringtemplate = 3.1-1.fc9 = jpackage-utils (no java dependency) ? %check is not present, but there seems to be a test suite upstream. I've no idea how to run it, though. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * %docs are not necessary for the proper functioning of the package. Java-specific bits: * no pre-built jars * single jar, named after the package * jarfiles are under _javadir. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review