Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Algorithm-FastPermute - Rapid generation of permutations https://bugzilla.redhat.com/show_bug.cgi?id=436754 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-04-04 00:44 EST ------- Builds fine and rpmlint is silent. I don't understand where you see the clarified Artistic license in the upstream source. The copyright information says: This module is free software. It may be used, redistributed and/or modified under the same terms as Perl itself. which would be "GPL+ or Artistic". Do you have some other source of licensing information for this software? * source files match upstream: 20b08432ac1aebaa2cf290e92344ae19073da6d87be464952a2a73f9718890f9 Algorithm-FastPermute-0.999.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field does not seem to match the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: FastPermute.so()(64bit) perl(Algorithm::FastPermute) = 0.999 perl-Algorithm-FastPermute = 0.999-1.fc9 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review