Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus https://bugzilla.redhat.com/show_bug.cgi?id=440246 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-04-03 23:03 EST ------- Builds fine and rpmlint finds nothing to complain about. According to the source (or commander.c, at least), the license is GPLv2+. Do you see anything that might restrict it to GPLv2 only? Everything else looks good to me. * source files match upstream: 415e3e257472c3f784eba43d0c298d2432491b20870f0cbe6beb6756692235f8 firecontrol-0.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: firecontrol = 0.2-1.fc9 = libraw1394.so.8()(64bit) * %check is not present; no test suite upstream. I have no way to test this software. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review