Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: latex2emf - Create an EMF file from LaTeX source https://bugzilla.redhat.com/show_bug.cgi?id=440211 michel.sylvan@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |michel.sylvan@xxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From michel.sylvan@xxxxxxxxx 2008-04-03 10:46 EST ------- Package meets naming and packaging guidelines: YES - Spec file matches base package name.: YES - Spec has consistent macro usage. YES - Meets Packaging Guidelines. YES - License: GPLv2+ - License field in spec matches: YES - License file included in package: YES - Spec in American English: YES - Spec is legible.: YES - Sources match upstream md5sum: MD5(OOoLatexEmf_noarch_src.tar.gz)= ad1ab04077828e91a4df906a850bc013 - Package needs ExcludeArch: NO - BuildRequires correct: YES (builds correctly in koji/mock, see under SHOULD items) - Spec handles locales/find_lang: N/A - Package is relocatable and has a reason to be.: N/A - Package has %defattr and permissions on files is good.: YES - Package has a correct %clean section. YES - Package has correct buildroot: YES %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content: YES - Doc subpackage needed/used.: NO - Packages %doc files don't affect runtime.: YES - Package compiles and builds on at least one arch. YES (F-9, x86_64) - Package has no duplicate files in %files. YES - Package doesn't own any directories other packages own. YES - Package owns all the directories it creates. N/A - rpmlint output. rpmlint latex2emf-1* : clean - final provides and requires are sane (glibc, rpmlib provides removed): yes SHOULD Items: - Should build in mock: YES - Should build on all supported archs: YES (see above) - Should function as described. YES: tested on F-9. Works on one source file, breaks on another: "cannot get font size for ..." - Should have sane scriptlets. YES - Should have subpackages require base package with fully versioned depend. N/A - Should have dist tag YES - Should package latest version YES Issues: Breaks on the one file I mentioned; documentation does not specify usage (-bb ? -transp ?). But these are issues for upstream. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review