Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: smc-fonts - malayalam opentype fonts https://bugzilla.redhat.com/show_bug.cgi?id=440373 ------- Additional Comments From rbhalera@xxxxxxxxxx 2008-04-03 08:13 EST ------- 1.The variable name for font directory is better be used as fontdir instead of xfontdir. 2. "%{_datadir}/fonts" should not be defined as fontdir, since %{_datadir}/fonts/smc-fonts is anyway being used as a common font directory for all packages, it should be the fontdir. Another problem with this is, the fc-cache in %post section is being run on %{_datadir}/fonts, resulting caching of all the fonts in /usr/share/fonts. Thus take care that the fc-cache runs on the intended directory only. 3. 'Source' should have been the direct download link to the upstream archive. 4. 'URL' should point to the projects homepage. In this case the savanna homepage for the smc project should be ok. 5. The installed font directory should have proper permissions defined as per given in the Font SIG's spec template. http://fedoraproject.org/wiki/SIGs/Fonts/Packaging/SpecTemplate -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review