Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnue-common - GNU Enterprise Common Base https://bugzilla.redhat.com/show_bug.cgi?id=439310 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-04-02 14:00 EST ------- The -2.src.rm you have made available still includes the previous version of the spec file. The uploaded spec is OK however and using it makes mock happy. No, a couple of small issues: The correct license, according to the .py files included in the tar.gz is GPLv2+. It would be awesome if you could use a single directory for all docs. Now some of them are under /usr/share/doc/gnue-common while others are in /usr/share/doc/gnue-common-0.6.9/. Not mandatory, but nicer. The changelog has a "%config" (second to last line in release 2) which triggers a rpmlint warning, please replace it with "%%config". Otherwise everything seems fine, I'll post a full review as soon as I manage to verify that it works. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review