Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rubberband - Audio time-stretching and pitch-shifting library https://bugzilla.redhat.com/show_bug.cgi?id=439744 alexl@xxxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From alexl@xxxxxxxxxxxxxxxxxxxxx 2008-04-02 07:58 EST ------- - Package meets naming and packaging guidelines: YES - Spec file matches base package name.: YES - Spec has consistant macro usage. YES - Meets Packaging Guidelines. YES - License: GPLv2+ - License field in spec matches: YES - License file included in package: YES - Spec in American English: YES - Spec is legible.: YES - Sources match upstream md5sum: eb9524064ae48d6a3af0779590ff4ebc rubberband-1.0.1.tar.bz2 - Package needs ExcludeArch: NO - BuildRequires correct: YES (builds correctly in koji/mock, see under SHOULD items) - Spec handles locales/find_lang: N/A - Package is relocatable and has a reason to be.: N/A - Package has %defattr and permissions on files is good.: YES - Package has a correct %clean section. YES - Package has correct buildroot: YES %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content: YES - Doc subpackage needed/used.: NO - Packages %doc files don't affect runtime.: YES - Headers/static libs in -devel subpackage.: YES - Spec has needed ldconfig in post and postun: YES - .pc files in -devel subpackage/requires pkgconfig: YES - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} : YES - .la files are removed. N/A - Package is a GUI app and has a .desktop file: N/A - Package compiles and builds on at least one arch. YES (F-8, i386) - Package has no duplicate files in %files. YES - Package doesn't own any directories other packages own. YES - Package owns all the directories it creates. YES - rpmlint output. rpmlint rubberband-1.0.1*.rpm rubberband-devel*.rpm rubberband-devel.i386: W: no-documentation (the warning can be ignored) - final provides and requires are sane (glibc, rpmlib provides removed): rubberband-1.0.1-1.fc8.i386.rpm ladspa-rubberband.so librubberband.so.1 vamp-rubberband.so rubberband = 1.0.1-1.fc8 = /sbin/ldconfig /sbin/ldconfig libfftw3.so.3 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libsamplerate.so.0 libsamplerate.so.0(libsamplerate.so.0.0) libsndfile.so.1 libsndfile.so.1(libsndfile.so.1.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libvamp-sdk.so.1.1.0 rtld(GNU_HASH) rubberband-devel-1.0.1-1.fc8.i386.rpm rubberband-devel = 1.0.1-1.fc8 = librubberband.so.1 pkgconfig rubberband = 1.0.1-1.fc8 SHOULD Items: - Should build in mock: YES, SRPM builds successfully on koji for f-9: http://koji.fedoraproject.org/koji/taskinfo?taskID=543841 - Should build on all supported archs: YES (see above) - Should function as described. YES: tested on F-8, stretches .wav files nicely - Should have sane scriptlets. YES - Should have subpackages require base package with fully versioned depend. YES - Should have dist tag YES - Should package latest version YES Issues: None. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review