Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pyPdf - PDF toolkit https://bugzilla.redhat.com/show_bug.cgi?id=438892 paul@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |paul@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From paul@xxxxxxxxxxxx 2008-04-01 06:38 EST ------- Review: - rpmlint clean - package naming satisfies python module naming guidelines - spec file name matches package name - package meets packaging guidelines - license is BSD, matches package - license text not in separate file, but included directly in python source files, which are of course packaged and thus license texts are included in the package - spec file written in English and is legible - sources match upstream (md5sum e15eca1a3ed4d5c0d86370784e552a92) - package builds OK in mock on i386 and x86_64 for Fedora 9 - buildreqs OK - no shared libraries, static libraries, header files, pkgconfig files, or locale files to worry about - package doesn't claim to be relocatable - directory ownership OK - no duplicate files - %defattr(...) present and correct in %files section - %clean section present and correct - %install section properly cleans buildroot first - macro usage is consistent - code, not content - docs don't affect runtime - not a GUI app, no desktop file needed - filenames are all ASCII - I haven't tested that the package functions OK as it's basically a library for use with other apps - no scriptlets or subpackages - no file dependencies Suggestions: Use a more specific files list, e.g. %{python_sitelib}/pyPdf* this helps catch future changes that create extra files in the package, which you might want to document further in the changelog etc. Include CHANGELOG in %doc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review