Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gbrainy - Gbrainy is a brain teaser game and trainer to keep your brain trained https://bugzilla.redhat.com/show_bug.cgi?id=436831 fedora@xxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxx 2008-03-29 11:40 EST ------- REVIEW : - rpmlint output 2 errors. Seems ok for mono. gbrainy.x86_64: E: no-binary gbrainy.x86_64: E: only-non-binary-in-usr-lib - The package is named according to the Package Naming Guidelines - The spec file name match the base package - The package meet the Packaging Guidelines - The package is licensed with a Fedora approved license - The License field in the package spec file match the actual license (GPLv2) - the text of the license(s) for the package is included in %doc. - The spec file for the package is be legible. - The sources used to build the package match the upstream source 9e85c503475f04955e48e1b2728700f4 gbrainy-0.61.tar.gz - successfully compile and build into binary rpms (F8 i386 + x86_64) - ExcludeArch : ppc64 - BuildRequires ok - locales ok - no shared libs - no duplicate files in the %files - Permissions on files are set properly - %clean section - consistently use macros - contain code - no Large documentation - %doc don't affect the runtime of the application - no header / library - include a %{name}.desktop - don't own files or directories already owned by other packages - %install, start with rm -rf %{buildroot} - filenames in rpm packages are valid UTF-8. - works fine (except i never find the answer, must be a bug) - build in mock (F8, i386) APPROVED Remember to file a bug against Bug #238953 (ExcludeArch Tracker for ppc64) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review