[Bug 439453] Review Request: sublib - a subtitle library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sublib - a subtitle library


https://bugzilla.redhat.com/show_bug.cgi?id=439453





------- Additional Comments From akahl@xxxxxxxxxxxxxx  2008-03-29 06:05 EST -------
(In reply to comment #0)
> + gacutil -i build/sublib.dll -f -package sublib -root
/var/tmp/sublib-0.8-1.fc8-root-jsikorski/usr/lib64
> Failure adding assembly to the cache: Attempt to install an assembly without a
strong name.

Upstream didn't bother to add a keyfile for strong naming
(http://www.mono-project.com/Assemblies_and_the_GAC#Assembly_Names), you can
either choose to inform upstream (sign a bug) and wait for them or do it yourself. 
For the latter, you need to create a new keyfile with 'sn -k sublib.snk' and -
this is important! - provide it as part of the SRPM (Source1) instead of
creating it dynamically as the key should be common amongst all builds, no
matter which architecture. Copy the resulting keyfile into sublib-0.8/src/ in
%prep and patch sublib-0.8/src/SubLib/AssemblyInfo.cs to have the following line
added:
[assembly: AssemblyKeyFile ("sublib.snk")]
Thus the assembly will be signed with the key file after the build and the
gacutil command above will succeed. If upstream ever chooses to provide their
own key for signing however, all builds depending on sublib must be rebuild
against the version with the new key IIRC. You could also opt to send them the
key you've created to circumvent this.

After finishing either one of the options given, I'll continue this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]