Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: stun - Implements the stun protocol Alias: stun-review https://bugzilla.redhat.com/show_bug.cgi?id=429496 mmahut@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Alias| |stun-review AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mmahut@xxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From mmahut@xxxxxxxxxx 2008-03-28 15:47 EST ------- Hey Huzaifa! - I don't like much download_name macro, I would use something like %{name}d and _%{version}__Aug13.tgz, but it's up to you :) - I would also separate -server to a subpackage - Use -p and -m with install - Change the license to Vovida Software License 1.0 (btw, this is Fedora/FSF compatible) - Does not build with gcc 4.3, you will have to patch it (http://koji.fedoraproject.org/koji/taskinfo?taskID=536657) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review