Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: amanda https://bugzilla.redhat.com/show_bug.cgi?id=225243 ------- Additional Comments From orion@xxxxxxxxxxxxx 2008-03-27 17:00 EST ------- (In reply to comment #5) > (In reply to comment #4) > > But isn't your new -pie patch missing some configure.in > stuff? I'd rather let it there... > The old pie patch had some stuff for configure.in, but it didn't do anything. It checked whether the compiler had pie support and set PIE_LDFLAGS (and some others) if so, but none of those variables were used anywhere. Now if upstream were to ever support this, they would require a working check in configure.in and proper modifying of the Makefile.am files. > I have also noticed these things: > > * The -lib patch, is it really needed? The package compiles just fine without > it. And after patching configure.in with -pie (see above), this gets overriden > by autogen. It fixes a problem that occurs when you try to build the amanda package on a machine with an older amanda-devel installed (because it ended up putting -L/usr/lib before the locally built lib path). Not going to happen in the fedora build system, but nice to not have others trip up on it. I've updated it to patch the sources. > * Why did the examples disappear from /usr/share/doc? I though it was good place > for such thing, people may be looking for it there... > Seemed like duplication to have in /etc/amanda/DailySet1 and there, but may make sense to keep. * Thu Mar 27 2008 Orion Poplawski <orion@xxxxxxxxxxxxx> 2.6.0-0.b3_20080314.1 - Update to 2.6.0b3_20080314 - New -lib patch that patches the autotool source files http://www.cora.nwra.com/~orion/fedora/amanda-2.6.0-0.b3_20080314.1.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review