Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: atop - An advanced interactive monitor to view the load on system and process level https://bugzilla.redhat.com/show_bug.cgi?id=430377 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-03-27 15:23 EST ------- There are a couple of small errors which need fixing a) in atop.spec: please do not start atop in %post. Fedora policy mandates to leave services stopped. It's up to the user to decide if the service should be started b) cron.daily should exit after checking if atop is started and finding out that it is not. Your script checks if atop is running, takes a last sample if it is and procedes with starting atop even if it is was not running I suggest: PID=`cat $PIDFILE` if [ -e $PIDFILE ] && ps -p $PID | grep 'atop$' > /dev/null then kill -USR1 $PID # take final sample sleep 3 kill -TERM $PID rm $PIDFILE sleep 1 else exit 1 fi A nice touch would be to use /etc/sysconfig/atop for storing all variables which now are defined at the start of atop.init and atop.crondaily (CURDAY, INTERVAL, PATHes etc) and source /etc/sysconfig/atop where ever it is needed. b) in atop.init: - you cannot use daemon to start a cron script, it's purpose is to daemonize a program - there is a typo error, CURDAY lacks the "C" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review