Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: anjuta - A GNOME development IDE for C/C++ https://bugzilla.redhat.com/show_bug.cgi?id=433199 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-03-27 14:10 EST ------- For 2.2.4-5: * License ----------------------------------------------------------- -License: GPLv2+ +Release: 5%{?dist} +# The Scintilla editor plugin is under MIT. +License: GPLv2+ and MIT ----------------------------------------------------------- - Well, libanjuta-scintilla.la is only used by libanjuta-editor.so, which is polluted by GPLv2+ from libanjuta.so so the license tag should still be GPLv2+ only (there is no libanjuta-scintilla.so in rpm). * PKGCONFIG ----------------------------------------------------------- +export PKG_CONFIG_PATH="./PKGCONFIG" %configure --disable-static --enable-gtk-doc --enable-devhelp \ --enable-plugin-glade --enable-graphviz --enable-plugin-sourceview \ --disable-plugin-valgrind --enable-plugin-subversion \ - --with-svn-lib=%{_libdir} + --with-svn-lib=%{_libdir} PKG_CONFIG_PATH=./PKGCONFIG ------------------------------------------------------------ - Perhaps the last "PKG_CONFIG_PATH=./PKGCONFIG" (as configure option) is not needed. (In reply to comment #24) > > * rpath issue > You seem to have left out /lib. I added it but that leads to the following > rpmlint error: > anjuta.src:103: E: hardcoded-library-path in /lib > > Can't we use /%{lib} or %{_libdir} instead of hardcoding the paths? - This is very intentional and here we must ignore this rpmlint error. Other things are okay. ------------------------------------------------------------------------------- This package (anjuta) is APPROVED by me (again) ------------------------------------------------------------------------------- ref: I once reviewed anjuta however at that time I didn't care about rpath issue or license issue or so :) https://bugzilla.redhat.com/show_bug.cgi?id=210464 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review