Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mapnik - a Free toolkit for developing mapping applications https://bugzilla.redhat.com/show_bug.cgi?id=436704 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-03-27 12:23 EST ------- For 0.5.0-0.2 * License - The license of mapnik is LGPLv2+. * Release number - If this tarball is created from svn repo, IMO it is better to include not date but svn revision number for Release tag. * Explicit library dependency ----------------------------------------------------------- Requires: boost Requires: zlib Requires: freetype Requires: proj Requires: gdal Requires: cairo Requires: cairomm ----------------------------------------------------------- - These library related requires should be catched by find_require.sh and these type of explicit Requries must be removed (except for some cases such as mono/java related packages) ----------------------------------------------------------- Requires: python ----------------------------------------------------------- - This requires is not needed and must be removed. * Requires for subpackages - Requires for -devel subpackage are not added automatically and you have to find out and add proper Requires. * Example: %_includedir/%name/jpeg_io.hpp contains ----------------------------------------------------------- 25 extern "C" 26 { 27 #include <jpeglib.h> 28 } ----------------------------------------------------------- This means that mapnik-devel should have "Requires: libjpeg-devel". The following command is useful for detecting such dependency. ----------------------------------------------------------- $ rpm -ql mapnik-devel | grep /usr/include | xargs grep -h 'include ' | sort | uniq ----------------------------------------------------------- - Similarly, please check the dependency for -python subpackage by ----------------------------------------------------------- $ rpm -ql mapnik-python | grep python | xargs grep -h 'import ' | sort | uniq ----------------------------------------------------------- * Fedora specific compilation flags - This is not yet correctly honored. * Use of system wide libraries - build.log shows ----------------------------------------------------------- 76 g++ -o agg/src/agg_vcgen_dash.o -c -O3 -fPIC -DNDEBUG -Iagg/include agg/src/agg_vcgen_dash.cpp 101 ar rc agg/libagg.a agg/src/agg_line_profile_aa.o ...... 190 g++ -o src/libmapnik.so .... -L/usr/local/lib -lagg -lfreetype .... ----------------------------------------------------------- Here libmapnik.so uses internal libagg.a, not libagg.so provided by agg-devel. Please apply patches so that libmapnik.so uses system-wide libagg.so - Also ------------------------------------------------------------ 166 g++ -o tinyxml/tinystr.os .... tinyxml/tinystr.cpp 190 g++ -o src/libmapnik.so .... tinyxml/tinystr.os ... ------------------------------------------------------------ Here libmapnik.so uses internal tinyxml, however Fedora has tinyxml-devel so please use system-wide tinyxml. - By the way Fedora's optimation level is -O2 and -O3 is not allowed. * Macros - Please use macros. For example, /usr must be %{_prefix}. * Fonts - Patch1 shows ------------------------------------------------------------- 19 datasource_cache::instance()->register_datasources(mapnik_dir + "/lib/mapnik/input/"); 20 - freetype_engine::register_font(mapnik_dir + "/lib/mapnik/fonts/DejaVuSans.ttf"); 21 + freetype_engine::register_font(mapnik_dir + "/usr/share/fonts/dejavu/DejaVuSans.ttf"); ------------------------------------------------------------- However /usr/share/fonts/dejavu/DejaVuSans.ttf does not exist on my system. * By the way is 'mapnik_dir + "/usr/...."' correct? - Also if you want to use dejavu fonts, it must be added to Requires (I am not talking about BuildRequires here). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review