Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-Levenshtein - Levenshtein distance measurement library in C https://bugzilla.redhat.com/show_bug.cgi?id=429882 ------- Additional Comments From dwayne@xxxxxxxxxxxxxxxx 2008-03-27 06:00 EST ------- Thanks David, (In reply to comment #5) > (In reply to comment #4) > [!] Rpmlint output: > source RPM: python-Levenshtein.src:26: E: use-of-RPM_SOURCE_DIR > binary RPM: empty > > You should rather use %SOURCE1 to refer to the location of the source file. > Also, this source file should be pointed to a URL from whence it can be > downloaded. It may be good to make a package for genextdoc, and then you can > just say BuildRequires and run it normally Fixed - not worth packaging genextdoc separately. > [?] Sources used to build the package matches the upstream source, as provided > in the spec URL. > This is hard to check because the original website has disappeared, and the spec > URL provided points to the translate package download copy. Either taking over > maintenance of the project, or getting the author to resurrect it would solve this. > I did check against versions from the web archive successfully: > SHA1SUM of tar.bz2:d630141e003f47a43e0f8eacdcbf593bf9d15ed6 > http://web.archive.org/web/20070305015113/trific.ath.cx/Ftp/python/levenshtein/python-Levenshtein-0.10.1.tar.bz2 Have left/tried to leave comment on the new blog. > Also as noted above, genextdoc.py should be placed on a public URL Not that critical I think. Its as valuable as a patch > Also, it would be good to use %{version} for the version in the source URL Fixed. > [?] Reviewer should test that the package builds in mock. > Tested on: devel/x86_64 > [?] Package should compile and build into binary rpms on all supported > architectures. > Tested on: i386 Not sure myself how to do a mock build Will upload new SRPM and SPEC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review