Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fsvs - full system versioning using subversion repositories https://bugzilla.redhat.com/show_bug.cgi?id=433778 ------- Additional Comments From davidf@xxxxxxxxxx 2008-03-25 09:41 EST ------- (In reply to comment #10) > Take this with a grain of salt, I did not do a thorough check: > - I suggest replacing all "/usr/bin" references with "%{_bindir} (see "mkdir -p > $RPM_BUILD_ROOT/usr/bin" and "cp -p src/fsvs $RPM_BUILD_ROOT/usr/bin") > - use %{_sysconfdir} and %{_var} in "%define conf_dir /etc/fsvs/" and "%define > waa_dir /var/spool/fsvs" > - /usr/share/doc/fsvs-1.1.13/ is included but not owned Good points, all oversights on my part - thanks for the fixes > - rpmlint has complains about the binary rpm: > fsvs.x86_64: W: spurious-executable-perm > /usr/share/doc/fsvs-1.1.13/example/var/lib/fsvs-versioning/scripts/shadow-clean.pl > fsvs.x86_64: W: spurious-executable-perm > /usr/share/doc/fsvs-1.1.13/example/var/lib/fsvs-versioning/scripts/remove-password-line.pl > fsvs.x86_64: W: spurious-executable-perm /usr/share/doc/fsvs-1.1.13/example/setup.sh > fsvs.x86_64: E: non-standard-executable-perm /usr/bin/fsvs 0775 > fsvs.x86_64: W: spurious-executable-perm > /usr/share/doc/fsvs-1.1.13/example/var/lib/fsvs-versioning/scripts/commit.sh > fsvs.x86_64: W: doc-file-dependency > /usr/share/doc/fsvs-1.1.13/example/var/lib/fsvs-versioning/scripts/remove-password-line.pl > /usr/bin/perl > fsvs.x86_64: W: doc-file-dependency > /usr/share/doc/fsvs-1.1.13/example/var/lib/fsvs-versioning/scripts/shadow-clean.pl > /usr/bin/perl I've removed the example directory as it's not critical to use, is designed for Debian, and only makes sense with the scripts executable. > - the mandatory RPM_OPT_FLAGS flags seem to be ignored. Unfortunately the > standard "CFLAGS="$RPM_OPT_FLAGS" make" and "make CFLAGS="$RPM_OPT_FLAGS"" > solutions did not work, so I think you should take a look at the source, > probably the Makefile needs patching. Exporting CFLAGS before the configure seems to pull it in at the configure stage, so I've done that > As of the explicit Requires, your test is flawed because you use --nodeps. As > shown below, they are not needed for the simple reason that rpmbuild's dep > checker adds them : > [wolfy@wolfy tmp]$ rpm -qp --requires > /home/wolfy/reports/fsvs/fsvs-1.1.13-1.fc9.x86_64.rpm > /bin/sh > /usr/bin/perl > libapr-1.so.0()(64bit) > libaprutil-1.so.0()(64bit) > libc.so.6()(64bit) > libc.so.6(GLIBC_2.2.5)(64bit) > libc.so.6(GLIBC_2.3)(64bit) > libc.so.6(GLIBC_2.3.4)(64bit) > libc.so.6(GLIBC_2.4)(64bit) > libdl.so.2()(64bit) > libdl.so.2(GLIBC_2.2.5)(64bit) > libgdbm.so.2()(64bit) > libpcre.so.0()(64bit) > libsvn_delta-1.so.0()(64bit) > libsvn_ra-1.so.0()(64bit) > libsvn_subr-1.so.0()(64bit) > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rtld(GNU_HASH) > The package was built locally in mock, without including any of the "Requires" lines Silly me, I should have tested that > I am attaching the modified spec which fixes most of the above mentioned issues. > The only rpmlint warning remaining is > fsvs.x86_64: E: non-standard-executable-perm /usr/bin/fsvs 0775 > which I think that must also be fixed, I see no reason for g+w > Adjusted as well, new version coming... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review