Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 ------- Additional Comments From packages@xxxxxxxxxxxxxxxxxx 2008-03-22 19:33 EST ------- * rpmlint: No Problems * Package named correctly: Yes * Patches named correctly: Yes * Spec file named correctly: Yes * Licence(s) acceptable: Yes * Licence field matches: Not Quite (!!) See below * Licence file installed: Yes and included upstream * Spec file in American English: Yes * Source matches upstream: Yes * Locales use %find_lang: N/A * Contains %clean: Yes * %install contain rm -rf %{buildroot} or similar: Yes * Specfile legible: Yes * Compiles and builds ok: Yes (mock i386/ppc/x86_64 in devel) * Calls ldconfig in %post/%postun for shlibs: N/A * Owns directories it creates: Yes * Duplicate files: No * Permissions set correctly: Yes * Consistent macro use: Generally yes (!!) see comments * Separate -doc needed (for large docs): N/A * %doc affects runtime: N/A * Headers and static libs in -devel: N/A * .pc files in -devel: N/A * .so in -devel: N/A * -devel requires base: N/A * Contains .la files: N/A * Owns files it didn't create: No * .desktop files included and installed correctly: Yes * Filenames valid UTF8: Yes 1. The files glSDL.h and glSDL.c are marked as LGPL, so the license field might need to be: # glSDL.h and glSDL.c are LGPL+, all others are GPLv2+ License: GPLv2+ and LGPL+ 2. Not a blocker, but macro usage could be improved a little, for example when referring to the man page. Damn, I was playing this game for over an hour, before I remembered I was in the middle of a review! :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review