Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libconcord - Library to talk to Logitech® Harmony® universal remote controls https://bugzilla.redhat.com/show_bug.cgi?id=438105 ------- Additional Comments From s-t-rhbugzilla@xxxxxxxxxxxxx 2008-03-22 02:25 EST ------- > I don't see this in the example spec files... Out of curiosity, what example spec files are you referring to? I haven't seen any, and I'd love to read them. I think the wiki only has snippets. > > 2) I don't think you need "Requires: /sbin/ldconfig" since it's part of > > the base> package set. > > > > If you are going to include this, it seems common to only require it for > > script execution time, e.g.: > > > > libgeda/devel/libgeda.spec:16:Requires(post): /sbin/ldconfig > > libgeda/devel/libgeda.spec:17:Requires(postun): /sbin/ldconfig > > It's a library so it's required. Are you sure? I searched the whole devel CVS tree, and it looks like all libraries only require ldconfig in post/postun, not for the entire package. Anyway. Hopefully I'll get a chance to do a real complete review this weekend. My gut instinct is that everything's OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review