Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: boinc-client - A platform for distributed computing Alias: boinc-client-review https://bugzilla.redhat.com/show_bug.cgi?id=433187 ------- Additional Comments From xjakub@xxxxxxxxxx 2008-03-21 19:15 EST ------- >- As %_localstatedir/lib/boinc is in %files lists, at %postun > %_localstatedir/lib/boinc/{boinc,error}.log are already deleted > at this time. But that's not a problem, is it? The command proceeds and succeeds without the files too and I find it correct to delete the rule when the package has been removed. It is also the recommended way mentioned in http://fedoraproject.org/wiki/PackagingDrafts/SELinux (I know it's a draft, but...). Obviously it just deletes the corresponding line in /etc/selinux/targeted/contexts/files/file_contexts.local >Then: > - Should {boinc,error}.log be removed at final removal? Yes, they should, _for_now_. As I wrote in the previous comment, when fixing the SELinux filetype solves the SELinux troubles with boinc, I'll move both of the logfiles directly to /var/log, remove them from the %files list and also remove all the SELinux related commands and dependency on policycoreutils. I find it so more proper (logs should be under /var/log, especially when SELinux targeted policy expects logrotate to rotate logs in that directory), second, we can get rid of additional dependency and third as the logs won't be in the %files section, they will remain after uninstallation (what I prefer). I'm waiting for some feedback, especially from Francesco who reported the problem. On the machines I can test it (4 pcs) I haven't seen any SELinux problems with 5.10.45-2 as far. > - If you think these two files can be removed at final removal, > then the above scriptlet is not needed. Why? As I expressed above, I find it correct to remove the rules and don't leave "garbage" after uninstallation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review