Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: viewmtn - Web interface for Monotone version control system https://bugzilla.redhat.com/show_bug.cgi?id=435842 thomas.moschny@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From thomas.moschny@xxxxxx 2008-03-21 12:34 EST ------- [x],[~] = ok, [!] = problem, [-] = not applicable [x] package meets naming guidelines [x] specfile is encoded in ascii or utf-8 [x] specfile matches base package name [x] specfile uses macros consistently [x] specfile is written cleanly [x] specfile is written in AE [x] changelog is present and has correct format [x] license matches actual license [x] license is open source-compatible [x] license text is included in package [x] source tag has correct url [x] source files match upstream md5sum: 1758f8b6340cca7d191b21fc25daf283 [x] latest version is packaged [x] summary is concise [x] dist tag is present [x] buildroot is correct [x] buildroot is prepped [x] %clean is present [x] proper build requirements [!] proper requirements python-paste doesn't seem to be needed. [-] uses %{?_smp_mflags} [-] uses %{optflags} [x] doesn't use %makeinstall [x] package builds at least on one architecture tested on: f8/x86_64 [x] packages installs and runs at least on one architecture tested on: f8/x86_64 [~] rpmlint is quiet viewmtn.noarch: E: non-standard-uid /var/cache/viewmtn-graph apache Seems necessary though to give apache write permissions to the cache. [~] final provides/requires look sane see above, python-paste doesn't seem to be needed. [-] ldconfig called in %post and %postun if required [x] code, not content [x] file permissions are appropriate [-] debuginfo package looks usable [x] config files marked as %config(noreplace) [x] owns all the directories it creates [-] static libraries in -devel subpackage [-] header files in -devel subpackage [-] development .so files in -devel subpackage [-] pkgconfig files in -devel subpackage, requires pkgconfig [-] no .la files [x] doesn't need a -docs subpackage [!] relevant docs are included You should include the original INSTALL file, together with a README.fedora file explaining how, in this package, viewmtn is hooked to the webserver. [x] doc files are not needed at runtime [-] provides a .desktop file, build-requires desktop-file-utils [-] uses %find_lang, build-requires gettext APPROVED. Please fix the two (minor) issues before releasing the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review