Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-decorator - Module to simplify usage of decorators https://bugzilla.redhat.com/show_bug.cgi?id=438354 tim.lauridsen@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From tim.lauridsen@xxxxxxxxxxxxxx 2008-03-21 06:00 EST ------- rpmlint is silent on both RPM & SRPM. MUST: * package is named appropriately * it is legal for Fedora to distribute this * license field matches the actual license. * license is open source-compatible. * specfile name matches %{name} * summary and description fine * correct buildroot * %{?dist} is used * package meets FHS (http://www.pathname.com/fhs/) * changelog format fine * Packager tag not used * Vendor tag not used * Distribution tag not used * License used and not Copyright * Summary tag does not end in a period * specfile is legible * package successfully compiles and builds on at least x86 * make sure lines are <= 80 characters * specfile written in American English * no -doc sub-package necessary * no libraries * no rpath * not a GUI app * no -devel sub-package necessary * macros used appropriately and consistently * no %makeinstall * install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot} * no locale data * split Requires(pre,post) into two separate lines * package not relocatable * package contains code * package owns all directories and files * no %files duplicates * %defattrs present ( %defattr(-, root, root, -)) * %clean present * %doc files do not affect runtime SHOULD: * package should build on i386 ? package should build in mock - I haven't tried, but I don't think it'll be a problem APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review