Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libconcord - Library to talk to Logitech® Harmony® universal remote controls https://bugzilla.redhat.com/show_bug.cgi?id=438105 ------- Additional Comments From s-t-rhbugzilla@xxxxxxxxxxxxx 2008-03-21 01:49 EST ------- A few more notes: 1) This might be GPLv3+ not GPLv2+. See my recent email on concordance-users requesting license clarification. 2) I haven't looked at the SRPM yet, but does it include the "examples" directory from CVS? If so, we should probably remove that directory, because those files certainly aren't GPL, and are probably (C) Logitech, who might not like Fedora distributing them. When using official releases, you'll certainly have to repackage the releases like I did for fxload (see the shell script and spec in fxload for how to do it) 3) The %defattr should probably specify explicit permissions, at least that's what I was told in my fxload review: %defattr(0644,root,root,0755) 4) You certainly shouldn't distribute *.a, and I *think* not *.la either, even in -devel. 5) My comment about making COPYING a %doc to fix the rpmlint warning about docs was incorrect; I misread that as being re: the main package, not -devel. Still, if you want to shut rpmlint up, there is a TODO there you could package in -devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review