Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: themonospot -application that can be used to scan an avi file and extract some informations about audio and video data flow https://bugzilla.redhat.com/show_bug.cgi?id=427674 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-03-20 11:56 EST ------- For 0.6.5.2-1: * License - As far as I checked the files in the tarball, there are no files which specifies the version of GPL. In this case, we regard the license tag as "GPL+" (i.e. GPL at any version) Please check the section 9 of GPL text. * Disttag - I recommend to use %?dist tag. http://fedoraproject.org/wiki/Packaging/DistTag Using this will make CVS process on Fedora easier.s * RPM_OPT_FLAGS - As in comment 49, this mono package doesn't call gcc or g++ and $RPM_OPT_FLAGS is not needed. * Empty %post, %postun - Please remove these. * %files entry - %defattr(-,root,root,-) is missing. - This time: -------------------------------------------------------- 228 warning: File listed twice: /usr/lib/themonospot/languages 229 warning: File listed twice: /usr/lib/themonospot/languages/English.lf 230 warning: File listed twice: /usr/lib/themonospot/languages/English.lf 231 warning: File listed twice: /usr/lib/themonospot/languages/Italiano.lf 232 warning: File listed twice: /usr/lib/themonospot/languages/Italiano.lf 233 warning: File listed twice: /usr/lib/themonospot/themonospot-base.dll 234 warning: File listed twice: /usr/lib/themonospot/themonospot.exe -------------------------------------------------------- ! Note When you write -------------------------------------------------------- %files %{_libdir}/%{name}/ -------------------------------------------------------- this contains the directory %_libdir/%name itself and all files/directories/etc under %_libdir/%name, while -------------------------------------------------------- %files %dir %{_libdir}/%{name} -------------------------------------------------------- contains the directory %_libdir/%name only. * Documents - Please add COPYING.GPL to %doc (note that the permission of this file should be 0644). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review