Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Controller-FormBuilder - Catalyst FormBuilder Base Controller https://bugzilla.redhat.com/show_bug.cgi?id=438088 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-03-18 21:45 EST ------- Review: + package builds in mock. Koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=521638 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0cd3b3fd61bfdc551cf8c0352853441b Catalyst-Controller-FormBuilder-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=16, 2 wallclock secs ( 1.52 cusr + 0.15 csys = 1.67 CPU) + Package perl-Catalyst-Controller-FormBuilder-0.04-1.fc9 => Provides: perl(Catalyst::Controller::FormBuilder) = 0.04 perl(Catalyst::Controller::FormBuilder::Action) perl(Catalyst::Controller::FormBuilder::Action::HTML::Template) perl(Catalyst::Controller::FormBuilder::Action::Mason) perl(Catalyst::Controller::FormBuilder::Action::TT) Requires: perl(CGI::FormBuilder) perl(CGI::FormBuilder::Source::File) perl(CGI::FormBuilder::Util) perl(Catalyst) perl(Class::Inspector) perl(File::Spec) perl(NEXT) perl(Scalar::Util) perl(Tie::IxHash) perl(base) perl(lib) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review