Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nagios-nsca - nagios passive check daemon https://bugzilla.redhat.com/show_bug.cgi?id=433547 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-03-18 17:56 EST ------- Xavier asked me to have a quick look. Sorry I couldn't get to it yesterday. A few meta-issues first: Xavier, if you indeed are reviewing this, you should assign the ticket to yourself and set the fedora-review flag to '?'. The summary of the ticket should match the submitted package name. Was it de I don't have any particular issues with the reviewer providing fixed packages, but Michael does need to respond to the stuff in comments 8 and 9 before this can move anywhere. I am unfamiliar with nagios and related software, so I can really only look at the basic packaging, which looks fine. I'm looking at the package linked in comment 9. The scriptlets aren't exactly the same as the recommended ones, but the differences are inconsequential. Do note, however, that the "|| :" bit only has an effect as the last executed command in a scriptlet; its sole purpose is to prevent the scriptlet from returning a nonzero exit code. Also note that I tend to just drop the bits of my review template that don't apply, such as debuginfo and compiler flag bits for a noarch package, and the GUI app bit for a non-gui app. They're just placeholders to remind me to check things when they apply. Finally, I see some source files that are obviously GPLv2+, and others (nsca.c, send_nsca.c) which say GPLv2. Someone should ping upstream and see if they intend GPLv2 only for the final product. Otherwise I don't think GPLv2+ is accurate for the license tag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review