Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Mail-mimeDecode - Encodes and Decodes MIME messages https://bugzilla.redhat.com/show_bug.cgi?id=436737 fedora@xxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxx 2008-03-16 10:55 EST ------- First comments : Package name if ok : php-pear-Mail-mimeDecode You should use %setup -q -c cd Mail_mimeDecode-%{version} Because package.xml is outside any directory in the tarball As you Require pear > 1.6.0, you can probably BuildRequires same version (not usefull to build if you can't install it). >From rpmlint : W: invalid-license PHP License You must fix version => PHP You must not own /usr/share/pear/Mail which is already owned by php-pear-Mail-Mime (which is required). It could be valuable to add a comment (for packager) on how to run test after installation : pear run-tests -p Mail_mimeDecode -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review