Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: exe - eXe eLearning XHTML editor https://bugzilla.redhat.com/show_bug.cgi?id=432205 ------- Additional Comments From lkundrak@xxxxxxxxxx 2008-03-15 10:06 EST ------- 1.) You install the .desktop file with desktop-file-install; Please add BuildRequires: desktop-file-utils 2.) Requires: firefox This doesn't seem correct to me. It doesn't work with seamonkey or konqueror? Wouldn't requiring webclient be better? 3.) This could possibly be conditionally present for fedora < 9 %{python_sitelib}/%{name}*.egg-info 4.) RPMLint: Needs some love; either address those or explain why are they harmless: exe.noarch: W: devel-file-in-non-devel-package /usr/share/exe/twisted/internet/iocpreactor/_iocp.c exe.noarch: W: devel-file-in-non-devel-package /usr/share/exe/twisted/spread/cBanana.c exe.noarch: E: arch-independent-package-contains-binary-or-object /usr/share/exe/templates/mimetex.cgi exe.noarch: W: class-path-in-manifest /usr/share/exe/templates/geogebra.jar By the way -- java file? You don't depend on java. exe.src:37: W: rpm-buildroot-usage %build rm -rf $RPM_BUILD_ROOT exe.src: E: no-cleaning-of-buildroot %install Move "rm -rf $RPM_BUILD_ROOT" from %build to %install 5.) Did you check the functionality? The package seemed to be problematic with my Firefox setup; I couldn't close the window, etc. I'll be more specific if it worked for you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review