Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pmtools - power management debugging tools https://bugzilla.redhat.com/show_bug.cgi?id=437397 ------- Additional Comments From lkundrak@xxxxxxxxxx 2008-03-14 23:12 EST ------- 1.) Source0: %{name}-%{version}.tar.gz Please replace with full URL 2.) Release: 1 Include the %{dist} tag 3.) Buildroot: %{_tmppath}/%{name}-%{version}-root Please use the standard BuildRoot: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 4.) ExclusiveArch: i386 x86_64 ia64 Consider using %{ix86} macro instead of i386 5.) %setup -q .. %build cd %{name}-%{version} ... %install ... cd %{name}-%{version} Those cds are not nice. Take a look at %setup -n http://www.rpm.org/max-rpm/s1-rpm-inside-macros.html 6.) Replace /usr/sbin with %{_sbindir} install acpidump/acpidump %{buildroot}/usr/sbin/acpidump install acpixtract/acpixtract %{buildroot}/usr/sbin/acpixtract install madt/madt %{buildroot}/usr/sbin/madt ... %files %defattr(-,root,root) /usr/sbin/acpidump /usr/sbin/acpixtract /usr/sbin/madt %doc README COPYING 7.) * Thu Mar 13 2008 Dave Jones <davej@xxxxxxxxxx> Include - version-release at the end (sans dist-tag) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review