Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disktype - Detect the content format of a disk or disk image https://bugzilla.redhat.com/show_bug.cgi?id=436637 ------- Additional Comments From josh.kayse@xxxxxxxxxxxxxxx 2008-03-13 12:21 EST ------- I'll take a shot at pre-review: MUST: + rpmlint output rpmlint is clean + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches actual package license + includes LICENSE file in %doc + spec file written in American English + spec file is legible + upstream sources match sources in the srpm + package successfully builds on at least one architecture i386, x86_64 + ExcludeArch bugs filed + BuildRequires list all build dependencies + %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content + large documentation files should go in -doc subpackage + files marked %doc should not affect package + header files should be in -devel + static libraries should be in -static + packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' + libfoo.so must go in -devel + -devel must require the fully versioned base + packages should not contain libtool .la files + packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages Optional: + if there is no license file, packager should query upstream + translations of description and summary for non-English languages, if available + builds in mock + builds on i386 and x86_64 ? review should test the package functions as described + scriptlets should be sane + pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin I would approve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review