Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: universalindentgui - Gui for Reformatting Source https://bugzilla.redhat.com/show_bug.cgi?id=436894 ------- Additional Comments From panemade@xxxxxxxxx 2008-03-12 23:50 EST ------- (In reply to comment #4) > 1. Without the Provides, refuses to install, saying > requires 'perl(PerlTidyLib)'. I know nothing about perl. I just added this > line as a guess as to what to do. I didn't see any problem with updated SRPM after I rebuilt it on rawhide removing that provides lines. Can you check again? > > 2. "Use some uniqueness..." I'm sorry - I don't understand. I mean to change %{_bindir}/%{name} %{_datadir}/%name to %{_bindir}/%{name} %{_datadir}/%{name} > > 3. Upstream made some fixes for us, now updated to svn634. This one passes > rpmlint with just 1 small warning. > > http://nbecker.dyndns.org:8080/RPM/universalindentgui-0.8.0.svn634-1.fc8.src.rpm > http://nbecker.dyndns.org:8080/RPM/universalindentgui.spec I see rpmlint warning each on RPM and SRPM. 1) As, you are using any patch now, can you remove lines related with applying patch in SPEC. 2) add following line to %prep chmod 644 doc/iniFileFormat.html Above 2 fixes will silent rpmlint. also, I see still source url is not as per guidelines. Sorry that I missed to give reference url in comment #13 check http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review